fix: loosen torch and torchaudio version constraints for Python 3.13+ compatibility - #4
Conversation
|
Thanks @cpiprint for the PR! Is this meant to fix #3? If so, I'd suggest a one-line change instead of loosening the torch pin. The real cause: This makes 3.13/3.14 fall through to the bundled CPython 3.11 (confirmed working on macOS in the issue thread). Want to give that a try? |
|
Also, do you mind dropping the |
|
Thanks for the feedback, @danielravina! That makes total sense. I reverted the torch pin adjustment and applied the upper-bound limit constraint (minor <= 12) to detectTools(). I also dropped the unrelated package changes as requested. The PR should be cleanly updated now! |
|
Thanks @cpiprint! the cap looks exactly right, nice work! One small thing: the revert of the |
joecer21
left a comment
There was a problem hiding this comment.
Looks right to me and solves the blocker on 1st time installs only.
However, for users that tried and failed before:
bootstrap() creates the venv without --clear, so a failed setup leaves a half-built venv that later runs reuse rather than rebuild. Anyone who already hit this stays broken even after. Their venv is still bound to 3.14, so the interpreter fix never reaches them.
Everyone on #3 had to rm -rf the venv by hand before the workaround took.
- const child = spawn(state.python.path as string, ['-m', 'venv', venv])
+ const child = spawn(state.python.path as string, ['-m', 'venv', '--clear', venv])bootstrap() only runs when setup is incomplete (a ready venv skips the setup screen entirely), so it can't wipe a working install, and pip's wheel cache keeps the rebuild cheap rather than re-downloading the ~2GB.
All yours if you want it, or I can send it as a separate PR after this merges.
|
Thanks, my friend. I was out on the road. |
Description
The local audio engine installer currently crashes on newer Mac and Windows environments running modern Python runtimes (like Python 3.13) because
torchandtorchaudioare strictly locked to==2.5.1. Python 3.13 cannot resolve those older pre-compiled versions, throwing aNo matching distribution foundbuild error.Changes Made
torch==2.5.1totorch>=2.5.1insrc/main/env.tstorchaudio==2.5.1totorchaudio>=2.5.1insrc/main/env.tsThis adjustment allows the app's internal child process builder to pull down the nearest compatible wheel file for whatever modern Python environment is present on the host device.