Repository navigation
v1.9.3 — a blank KNAG_ENV is unknown, never local
A deploy that skipped the --var flags believed it was running on a laptop, and a laptop is where knag prints login codes to the log.
Fixed
-
A blank
KNAG_ENVread aslocal(#248). The var is baked at deploy by--var, which only the Makefile and the two deploy workflows pass; a plainwrangler deployshipped the committed default, which was"". Every reader spelled the fallbackKNAG_ENV || "local", so such a deploy would takesendMail's local branch — and that branch writes the six-digit login code into the log, the one thing ADR-008 §9 says must never reach a real deployment's observability. It also reportedlocalat/health, the field that exists so a deploy to the wrong environment can be told from one that failed.Blank now fails closed:
envName()answersunknown, the code is withheld, and the misconfiguration is logged as one.localbecame a value the local entry points pass out loud —pnpm devandscripts/dev-lan.shboth send--var KNAG_ENV:local.Nothing in dev or prod was affected. Both workflows bake the var, so neither has ever shipped a blank one. It was reachable only by a deploy nothing performs today — which is exactly what a Deploy to Cloudflare button would perform (#247).
Changed
- The committed defaults name an environment instead of nothing:
selfhostat the top level,produnderenv.prod. selfhostwears the prod tile and no subject-line tag. Both marks exist to tell two installs apart, and a self-hosted knag is somebody's only one.localkeeps the mark — dev-lan on a phone sits beside prod on the same home screen.
Full changelog: v1.9.2...v1.9.3