Fixed #7502 (Correct exit code if never used function is found) #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I will review this when CI is happy. it seems that on AppVeyor there are some unusedFunction assertion errors. Possibly these are fixed if it is re-run. |
ivmai
force-pushed
the
ret-exitcode-on-unused-function
branch
from
905ca87 to
ffbb9b6
Compare
Contributor
Author
|
All tests now pass after a slight (semantically equivalent) modification of the assertion condition. It's strange that previous commit led to an assertion failure on MS VS 10.0 (and only in case of Release build). |
ivmai
added a commit
to ivmai/cppcheck
that referenced
this pull request
Feb 1, 2018
…nmar#1026) This is a fix of commit 97ffec8.
danmar
pushed a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes https://trac.cppcheck.net/ticket/7502 ticket by returning error flag from analyseWholeProgram. The provided test case in the ticket succeeds now.