Suppressed unused functions should not lead to non-zero exit code #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The default implementation of hasErrors() is needed at least for tests. |
danmar
reviewed
Feb 3, 2018
lib/checkbufferoverrun.cpp
Outdated
| CWE788, false); | ||
| errorLogger.reportErr(errmsg); | ||
| errors = true; | ||
| if (errorLogger.hasErrors()) |
Owner
There was a problem hiding this comment.
I would like that we put this logic in lib/cppcheck.cpp instead. It's clumpsy that I have to remember this every time I add whole program analysis.
bool CppCheck::analyseWholeProgram()
{
.....
return errors && errorLogger.hasErrors();
}
Contributor
Author
There was a problem hiding this comment.
I agree with your concern.
But I don't have a clear vision how to put the logic in cppcheck,cpp.
Owner
There was a problem hiding this comment.
hmm.. doesnt it help to modify the existing CppCheck::analyseWholeProgram() as I suggested?
Contributor
Author
There was a problem hiding this comment.
Aha, got it. Done, please review.
ivmai
force-pushed
the
zero-exitcode-if-suppressed-unused-func
branch
from
bd46016 to
688906a
Compare
Owner
|
hmm.. that was not how I envisioned that it would work. I will merge this and try to change it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of commit 97ffec8 (of pull request #1026)
Tobias Burnus tobias.burnus@physik.fu-berlin.de reported me this issue:
To my problem: We use cppcheck with
--error-exitcode=1
--suppress=unusedFunction:xptiles.cc:805
Since the following patch that fails because cppcheck returns
the exit code 1 (as an unused function is found) but the patch
does not honor that it can be suppressed.
Namely, the test in lib/checkunusedfunctions.cpp's CheckUnusedFunctions::check
finds an unused function - and, hence, uses:
unusedFunctionError(errorLogger, filename, func.lineNumber, it->first);
errors = true;
This commit fixes the issue.