DAOS-19244 packaging: create /var/daos writable by daos_server#18626
Conversation
Add a /var/daos directory that is writeable for daos_server, which can then be used as a persistent location for control_meta and the mountpounts for the SCM/tmpfs filesystems (which should not be placed into /tmp). Signed-off-by: Michael Hennecke <michael.hennecke@hpe.com>
Michael-Hennecke
requested review from
daltonbohning,
phender,
rpadma2,
ryon-jensen and
tanabarr
|
Ticket title is '/tmp/<cluster_name>/logs/control_metadata/daos_control directory is not available after node reboot on aurora (DAOS nodes) [MDonSSD]' |
fix typo Signed-off-by: Michael Hennecke <michael.hennecke@hpe.com>
update daos.spec with changes from daos.sh Signed-off-by: Michael Hennecke <michael.hennecke@hpe.com>
tanabarr
left a comment
tanabarr
left a comment
There was a problem hiding this comment.
should we change any default locations within the product code based on this change?
Michael-Hennecke
changed the title
yes, after this lands we should change the server.yml example files to use this persistent location. i would do this in a separate PR. for control_meta, i thik there is no default in the code itself, correct? |
|
please land - trivy scan error is unrelated. |
phender
left a comment
phender
left a comment
There was a problem hiding this comment.
For changes like this we should be adding tests to confirm the change - ci/rpm/test_daos_node.sh would be a good place to verify the /var/daos exists, is owned by the correct user, and persists or is removed upon RPM removal.
Makes sense for the creation, although i'd point out that we do not have a check for the /var/log/daos creation either ;-) For the RPM uninstall, my personal take would be to not remove that directory, it may contain other data relevant to the admin that they do not want removed. |
…) (#18629) Add a /var/daos directory that is writable for daos_server, which can then be used as a persistent location for control_meta and the mountpounts for the SCM/tmpfs filesystems (which should not be placed into /tmp). Signed-off-by: Michael Hennecke <michael.hennecke@hpe.com>
5 participants
Add a /var/daos directory that is writable for daos_server, which can then be used as a persistent location for control_meta and the mountpounts for the SCM/tmpfs filesystems (which should not be placed into /tmp).