DAOS-19377 build: make pipeline a runtime feature toggle - #18732
Merged
Conversation
Remove the BUILD_PIPELINE compile-time define and replace it with the DAOS_PIPELINE environment variable (disabled by default). The client and server init/fini now enable pipeline support at runtime based on this variable, and the pipeline code is always compiled into libdaos. Update the pipeline test suites to compile unconditionally and gate execution on DAOS_PIPELINE, and set DAOS_PIPELINE=1 for the client and server when running the daos_test suite. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
|
Ticket title is 'Remove BUILD_PIPELINE and make it a runtime env' |
Co-authored-by: Dalton Bohning <dalton.bohning@hpe.com> Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
Collaborator
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18732/3/execution/node/533/log |
Comment on lines
+258
to
+259
| if (!pipeline_enabled) | ||
| skip(); |
Contributor
There was a problem hiding this comment.
Want to print a message? FWIW we do print this for FAULT_INJECTION_REQUIRED
print_message("Fault injection required for test, skipping...\n");
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
daltonbohning
approved these changes
Jul 28, 2026
wangshilong
approved these changes
Jul 29, 2026
mchaarawi
added a commit
that referenced
this pull request
Jul 29, 2026
…8743) Remove the BUILD_PIPELINE compile-time define and replace it with the DAOS_PIPELINE environment variable (disabled by default). The client and server init/fini now enable pipeline support at runtime based on this variable, and the pipeline code is always compiled into libdaos. Update the pipeline test suites to compile unconditionally and gate execution on DAOS_PIPELINE, and set DAOS_PIPELINE=1 for the client and server when running the daos_test suite. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
mchaarawi
added a commit
that referenced
this pull request
Jul 30, 2026
…8744) Remove the BUILD_PIPELINE compile-time define and replace it with the DAOS_PIPELINE environment variable (disabled by default). The client and server init/fini now enable pipeline support at runtime based on this variable, and the pipeline code is always compiled into libdaos. Update the pipeline test suites to compile unconditionally and gate execution on DAOS_PIPELINE, and set DAOS_PIPELINE=1 for the client and server when running the daos_test suite. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
mchaarawi
added a commit
that referenced
this pull request
Jul 30, 2026
…8745) Remove the BUILD_PIPELINE compile-time define and replace it with the DAOS_PIPELINE environment variable (disabled by default). The client and server init/fini now enable pipeline support at runtime based on this variable, and the pipeline code is always compiled into libdaos. Update the pipeline test suites to compile unconditionally and gate execution on DAOS_PIPELINE, and set DAOS_PIPELINE=1 for the client and server when running the daos_test suite. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the BUILD_PIPELINE compile-time define and replace it with the DAOS_PIPELINE environment variable (disabled by default). The client and server init/fini now enable pipeline support at runtime based on this variable, and the pipeline code is always compiled into libdaos.
Update the pipeline test suites to compile unconditionally and gate execution on DAOS_PIPELINE, and set DAOS_PIPELINE=1 for the client and server when running the daos_test suite.
Steps for the author:
After all prior steps are complete: