DAOS-19368 object: make fill_[key|rec] do not return error codes - #18767
DAOS-19368 object: make fill_[key|rec] do not return error codes#18767janekmi wants to merge 2 commits into
Conversation
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'Aurora daos_user: Observed Error message in log "DER_KEY2BIG(-2012): 'Key is too large'" while doing rebuild' |
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18767/1/execution/node/1713/log |
| return -DER_KEY2BIG; | ||
| } else { | ||
| return 1; | ||
| arg->rc_key2big = 1; |
There was a problem hiding this comment.
This flag should not be set for the original 'else' case.
There was a problem hiding this comment.
It is not. The condition remains in place. The only difference is that regardless if the condition is met or not the return value is now the same.
Please take a look again and write a suggestion to better explain the problem you see.
| D_DEBUG(DB_IO, "enum type %d rc %d\n", type, rc); | ||
| D_DEBUG(DB_IO, "enum type %d rc %d rc_key2big %d\n", type, rc, arg->rc_key2big == 1); | ||
|
|
||
| if (arg->rc_key2big) { |
There was a problem hiding this comment.
Clear this flag at the beginning of this function in case the caller retries.
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
3 participants
Steps for the author:
After all prior steps are complete: