Fix interactive key reader fd flags - #34
Merged
Merged
Conversation
dapi
marked this pull request as ready for review
July 24, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33.
What changed
The Unix interactive key reader now opens the controlling terminal as a separate file description before enabling
O_NONBLOCK. Teardown restores and closes only that reader descriptor, leaving stdin and any stdout/stderr descriptors sharing the original open-file description untouched.Root cause
O_NONBLOCKis an open-file-description flag. Setting it on stdin made stdout non-blocking when both descriptors shared that description, allowing normal terminal backpressure to abort the workflow.Routing and validation
Verification
go test ./internal/terminalgo test ./...go vet ./...make docs-lintgit diff --checkNo manual terminal smoke was run in the non-interactive execution environment.