Gloas lookup sync fixes (rebased on unstable)#73
Closed
Conversation
- Don't return ParentUnknown for zero-hash (genesis) parent - Track failed_processing counter to prevent infinite retries All 85 network tests pass
Replace the placeholder `payload_lookup_request` with actual RPC wiring. The full path is now: - network_context: sends PayloadEnvelopesByRoot request to peer - router: forwards responses to sync manager - manager: dispatches to block_lookups - single_block_lookup: updates PayloadRequest state machine This enables lookups to actually download envelopes from peers instead of returning NoRequestNeeded.
Owner
Author
|
Pushed to #68 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased version of #68 on current
sigp/unstablewith PayloadEnvelopesByRoot RPC wiring.Changes from #68 (cherry-picked)
single_block_lookup.rs)on_completed_requestno-op + clear all peer sets on disconnectNew: Wire PayloadEnvelopesByRoot RPC
Replaces the placeholder
payload_lookup_request(which returnedNoRequestNeeded) with actual RPC wiring:network_context: sendsPayloadEnvelopesByRootrequest, tracks inActiveRequestsrouter: forwards responses to sync managermanager: dispatches toblock_lookupssingle_block_lookup: updatesPayloadRequeststate machinePayloadEnvelopesByRootRequestItemsrequest accumulatorTest plan