Remove mentions of backoff from rabbitmq docs #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent change, the rabbitmq component dropped support for backoff policies. This updates the documentation page by leaving those out as well. Signed-off-by: Renato L. de F. Cunha <renatocunha@acm.org>
ItalyPaleAle
reviewed
Dec 6, 2022
| ### Enabling message delivery retries | ||
|
|
||
| Backoff retry strategy can instruct the dapr sidecar how to resend the message. By default, the retry strategy is turned off, which means that the sidecar will send a message to the service once. When the service returns a result, the message will be marked as consumption regardless of whether it is correct or not. The above is based on the condition of `autoAck` and `requeueInFailure` is setting to false(if `requeueInFailure` is set to true, the message will get a second chance). | ||
| The rabbitmq pubsub component has no built-in support for retry strategies. This means that the sidecar will send a message to the service only once. When the service returns a result, the message will be marked as consumed regardless of whether it was processed correctly or not. |
Contributor
There was a problem hiding this comment.
Note that this is common among all PubSub components and not just RabbitMQ. Users should use Resiliency if they want in-process retries.
What’s important to note is the difference between the two ways to retry messages:
- When using
autoAck = falseandrequeueInFailure = true, RabbitMQ is the one responsible for re-delivering messages and any subscriber can get the redelivered message. If you have more than one instance of your consumer, then it’s possible that another consumer will get it. This is usually the better approach because if there’s a transient failure, it’s more likely that a different worker will be in a better position to successfully process the message. - Using Resiliency (and the deprecated backoff policy) makes the same Dapr sidecar retry redelivering the messages. So it will be the same Dapr sidecar and the same app receiving the same message.
Contributor
Author
There was a problem hiding this comment.
Sorry for not getting back at this earlier. I see that @msfussell made some more changes to this PR and approved them.
I like this explanation and I've incorporated it into the PR. Please let me know what you think, @ItalyPaleAle.
hhunter-ms
requested changes
Dec 8, 2022
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
|
Stale PR, paging all reviewers |
…ubsub/setup-rabbitmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Mark Fussell <markfussell@gmail.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Mark Fussell <markfussell@gmail.com>
…ubsub/setup-rabbitmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Mark Fussell <markfussell@gmail.com>
msfussell
reviewed
Dec 14, 2022
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-rabbitmq.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
msfussell
reviewed
Dec 14, 2022
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-rabbitmq.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
msfussell
reviewed
Dec 14, 2022
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-rabbitmq.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Renato L. de F. Cunha <renatocunha@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent change, the rabbitmq component dropped support for backoff policies. This updates the documentation page by leaving those out as well.
Signed-off-by: Renato L. de F. Cunha renatocunha@acm.org
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
I've removed the outdated mentions of
backofffrom the RabbitMQ pubsub component page.Issue reference
#2977
dapr/dapr#1798