Skip to content

Remove backoff from pubsub #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 3, 2023
Merged

Remove backoff from pubsub #2986

merged 24 commits into from
Feb 3, 2023

Conversation

@shivamkm07
Copy link
Contributor

@shivamkm07 shivamkm07 commented Dec 2, 2022

Signed-off-by: shivam shivamkm07@gmail.com

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Remove backoff from remaining places in mqtt and pulsar. For rabitmq, another PR is open #2978 . Backoff was removed from pusub component in 1.9: dapr/components-contrib#1798

Issue reference

@shivamkm07 shivamkm07 requested review from a team as code owners December 2, 2022 10:58
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 8, 2022
@hhunter-ms hhunter-ms removed the stale label Dec 8, 2022
shivamkm07 and others added 2 commits December 12, 2022 09:54
@shivamkm07
Remove backoff from pubsub
95e8b88 
Signed-off-by: shivam <shivamkm07@gmail.com>
@shivamkm07 @hhunter-ms
Update daprdocs/content/en/reference/components-reference/supported-p…
291574a 
…ubsub/setup-pulsar.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
@msfussell
Copy link
Member

msfussell commented Dec 14, 2022

@shivamkm07 - As was done for the RabbitMQ component, in the PR #2978, I suggest that for both MQTT and Pulsar components we add a paragraph on using a resiliency policy. Like this below

To enable sophisticated retry policies, you can apply a [retry resiliency policy]({{< ref "policies.md#retries" >}}) to the MQTT pub/sub component to retry failed messages.

@msfussell msfussell added this to the 1.9 milestone Dec 14, 2022
@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 26, 2022
@hhunter-ms hhunter-ms removed the stale label Jan 3, 2023
@hhunter-ms
Copy link
Contributor

hhunter-ms commented Jan 3, 2023

@shivamkm07 - As was done for the RabbitMQ component, in the PR #2978, I suggest that for both MQTT and Pulsar components we add a paragraph on using a resiliency policy. Like this below

To enable sophisticated retry policies, you can apply a [retry resiliency policy]({{< ref "policies.md#retries" >}}) to the MQTT pub/sub component to retry failed messages.

@shivamkm07 were you able to update both files in this PR with this paragraph?

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 10, 2023
Adding retry messages
d7e71a6 
Signed-off-by: Shivam Kumar <shivamkumar@Shivams-MacBook-Pro.local>
@shivamkm07
Copy link
Contributor Author

shivamkm07 commented Jan 14, 2023 •
edited
Loading

@shivamkm07 - As was done for the RabbitMQ component, in the PR #2978, I suggest that for both MQTT and Pulsar components we add a paragraph on using a resiliency policy. Like this below
To enable sophisticated retry policies, you can apply a [retry resiliency policy]({{< ref "policies.md#retries" >}}) to the MQTT pub/sub component to retry failed messages.

@shivamkm07 were you able to update both files in this PR with this paragraph?

@hhunter-ms @msfussell Sorry missed this PR for long.

Updated the paragraphs in both Pulsar and mqtt. Please review

@github-actions github-actions bot removed the stale label Jan 15, 2023
hhunter-ms
hhunter-ms approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @msfussell ?

msfussell and others added 2 commits January 20, 2023 12:11
@msfussell @DeepanshuA
Update daprdocs/content/en/reference/components-reference/supported-p…
784387d 
…ubsub/setup-mqtt.md

Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Mark Fussell <markfussell@gmail.com>
@msfussell
Merge branch 'v1.9' into fix-mqttsetup-1.9
3ccce5b
@shivamkm07 @msfussell
Apply suggestions from code review
01b7887 
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
@shivamkm07
Copy link
Contributor Author

shivamkm07 commented Jan 24, 2023

Done @msfussell

@hhunter-ms
Copy link
Contributor

hhunter-ms commented Jan 30, 2023 •
edited
Loading

@shivamkm07 do you mind fixing the broken link? I think it's this now: https://strimzi.io/quickstarts/

@shivamkm07
Fixing broken link
d78a255 
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
@shivamkm07
Copy link
Contributor Author

shivamkm07 commented Feb 1, 2023

@shivamkm07 do you mind fixing the broken link? I think it's this now: https://strimzi.io/quickstarts/

Done @hhunter-ms

msfussell
msfussell approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit f49400e into dapr:v1.9 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfussell msfussell msfussell approved these changes

@hhunter-ms hhunter-ms hhunter-ms approved these changes

@DeepanshuA DeepanshuA Awaiting requested review from DeepanshuA

Assignees

@shivamkm07 shivamkm07

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

4 participants

@shivamkm07 @msfussell @hhunter-ms @DeepanshuA