Integration test stabilization + update proto and Dapr runtime to 1.12 RC. by artursouza · Pull Request #917 · dapr/java-sdk

artursouza · 2023-09-20T04:36:57Z

Description

Update Dapr runtime to 1.12 RC.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: endgame

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

…12cd099 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

…773cf6b Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

…fc3b01 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza · 2023-09-27T05:35:20Z

      if: env.DAPR_REF != ''
      with:
-        repository: dapr/dapr
+        repository: artursouza/dapr


Temporary until the fix is merged in runtime. Don't merge this yet.

artursouza · 2023-09-27T05:35:54Z

 * Service for subscriber.
 */
+@DaprRunConfig(
+        enableAppHealthCheck = true


This is a must to avoid a race condition between invoking a service and it being available.

artursouza · 2023-09-27T05:38:38Z


+    // The artificial delay is useful to detect bugs in app health, where the app is invoked too soon.
+    System.out.printf("Artificial delay of %d seconds ...\n", STARTUP_DELAY_SECONDS);
+    Thread.sleep(STARTUP_DELAY_SECONDS * 1000);


This allows the issue to be reproduced locally, 100% of the time.

mukundansundar · 2023-09-27T06:20:11Z

@artursouza Just one question, as a whole we are waiting for Dapr to be completely ready before invoking any service right?

The E2E are still failing on the MethodInvokeITs

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

…74e3bc3329 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza · 2023-09-28T01:42:54Z

@artursouza Just one question, as a whole we are waiting for Dapr to be completely ready before invoking any service right?

Yes but with this change, I am also waiting for the app's health endpoint.

artursouza · 2023-09-28T01:43:34Z

+      DAPR_INSTALL_URL: https://raw.githubusercontent.com/dapr/cli/v1.12.0-rc.1/install/install.sh
      DAPR_CLI_REF:
-      DAPR_REF:
+      DAPR_REF: 72b6f7374a670c3054427aa2b01d2374e3bc3329


This is a fix that allows runtime's grpc app channel to recover.

…bdde388 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

codecov · 2023-09-30T04:38:20Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (96c0418) 76.19% compared to head (a346a3c) 76.19%.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #917   +/-   ##
=========================================
  Coverage     76.19%   76.19%           
  Complexity     1433     1433           
=========================================
  Files           135      135           
  Lines          4399     4399           
  Branches        518      518           
=========================================
  Hits           3352     3352           
  Misses          766      766           
  Partials        281      281

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

artursouza · 2023-10-02T16:15:23Z

Force merging this to unblock the release.

artursouza requested review from a team as code owners September 20, 2023 04:36

Update Dapr runtime to 1.12 RC.

ff206d7

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

mukundansundar previously approved these changes Sep 20, 2023

View reviewed changes

mukundansundar added the auto-merge label Sep 20, 2023

Merge branch 'master' into update_1_12_rc

33bd408

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

artursouza dismissed mukundansundar’s stale review via 33bd408 September 20, 2023 20:44

artursouza and others added 6 commits September 24, 2023 15:29

Merge branch 'master' into update_1_12_rc

960c5a1

Add socket wait for ToxiProxy client.

8e66406

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Changing ambiguity in service Id for TracingIT tests.

6557042

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

More assertions to SDKResiliencyIT.

b3d7c5d

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Add sidecar wait for TracingIT.

7fb5922

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Wait for Zipkin endpoint.

7a1db95

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

mukundansundar mentioned this pull request Sep 25, 2023

upgrade dapr and cli to latest RCs #927

Closed

3 tasks

artursouza added 16 commits September 25, 2023 14:19

Tacking flakiness on MethodInvokeIT and TracingIT.

ecd7a64

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Merge remote-tracking branch 'upstream/master' into update_1_12_rc

5d2adde

Test again with 1.11.0 CLI.

464d177

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Start bisect 1.12 regression.

55365bf

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Bisect step for runtime at 34c5102600b5a39704089b72db565ca95943269d

71c899f

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

bisect step for runtime at ad5618711830510617e1b8fb2d0c6758f14ff6b9

7c98afb

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

bisect step for runtime at 4e5c51be62d8a7319ab25a401681ba82bd3ef7e7

ea203bf

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

git bisect step for runtime at 3143f2fcb679e585d978e9b9d706cce72088fecc

2c61e3e

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

git bisect step for runtime at d243d1c6a17b019e0435ebbc10abb00810beb29a

cf1d563

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

git bisect step for runtime at 2ddb99be5ae61abd9f7f3616987fcfda0cedbc6e

4ff6b4d

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

git bisect step for runtime at 0fdab70eb32a63dd2630c39c4b1bc623212cd099

cafb968

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

git bisect step for runtime at b42319279f21ee5c63d5cd04bfef6e94897cf34f

9b15772

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Verify first bad commit at runtime: 0fdab70eb32a63dd2630c39c4b1bc6232…

57ea21f

…12cd099 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Trying artursouza/dapr at 37ca4c81041de11677ddea101298ca3c2ad8585d

edada0a

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Add delay of 10s on MethodInvokeService for IT.

4cadcd4

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Trying dapr at artursouza's fork at 65e117433284388535f5a967456611a72…

c68b5fe

…773cf6b Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza added 3 commits September 26, 2023 22:21

Change MethodInvokeService to use AppHealthCheck.

c1ea00b

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Change TracingIT to use AppHealthCheck.

7625d3f

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Change to use artursouza's fork at f770694b3fbf7222c162a4ee4e13818a5a…

953a307

…fc3b01 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza commented Sep 27, 2023

View reviewed changes

Comment thread .github/workflows/build.yml Outdated

artursouza commented Sep 27, 2023

View reviewed changes

artursouza changed the title ~~Update proto and Dapr runtime to 1.12 RC.~~ Integration test stabilization + update proto and Dapr runtime to 1.12 RC. Sep 27, 2023

artursouza commented Sep 27, 2023

View reviewed changes

mukundansundar removed the auto-merge label Sep 27, 2023

mukundansundar previously approved these changes Sep 27, 2023

View reviewed changes

artursouza added 3 commits September 27, 2023 15:23

Remove use of artursouza's fork for runtime.

ac4c63a

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Fix MethodInvokeIT to actually use AppHealthCheck.

05facbf

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Try fix in runtime: artursouza/dapr at 72b6f7374a670c3054427aa2b01d23…

da912c7

…74e3bc3329 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza commented Sep 28, 2023

View reviewed changes

artursouza mentioned this pull request Sep 28, 2023

[release-1.12] Fix issue where gRPC app channel cannot recover from no connection. dapr/dapr#6977

Merged

7 tasks

artursouza added 4 commits September 28, 2023 09:47

Trying runtime as per artursouza at 64d19957059d134378603630165b3e473…

23602ca

…bdde388 Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Increase delay to avoid race condition for app health checks.

8f6e464

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Try runtime at artursouza at d2eb15d1707ff8539ff1561a1fd67750d205854b

f78fc20

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Update to 1.12.0-rc.5

a346a3c

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

artursouza merged commit 7f76d5b into dapr:master Oct 2, 2023

mukundansundar approved these changes Oct 2, 2023

View reviewed changes

mukundansundar mentioned this pull request Oct 3, 2023

Service Invocation Tests are extremely flaky in Java SDK #932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Integration test stabilization + update proto and Dapr runtime to 1.12 RC.#917

Integration test stabilization + update proto and Dapr runtime to 1.12 RC.#917
artursouza merged 34 commits into
dapr:masterfrom
artursouza:update_1_12_rc

artursouza commented Sep 20, 2023 •

edited

Loading

Uh oh!

Uh oh!

artursouza Sep 27, 2023

Uh oh!

artursouza Sep 27, 2023

Uh oh!

artursouza Sep 27, 2023 •

edited

Loading

Uh oh!

mukundansundar commented Sep 27, 2023

Uh oh!

artursouza commented Sep 28, 2023

Uh oh!

artursouza Sep 28, 2023

Uh oh!

codecov Bot commented Sep 30, 2023

Uh oh!

artursouza commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

artursouza commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

Uh oh!

artursouza Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

artursouza Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

artursouza Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukundansundar commented Sep 27, 2023

Uh oh!

artursouza commented Sep 28, 2023

Uh oh!

artursouza Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 30, 2023

Codecov Report

Uh oh!

artursouza commented Oct 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

artursouza commented Sep 20, 2023 •

edited

Loading

artursouza Sep 27, 2023 •

edited

Loading