Fix codecov#1135
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 86.63% 82.12% -4.51%
==========================================
Files 84 117 +33
Lines 4473 9537 +5064
==========================================
+ Hits 3875 7832 +3957
- Misses 598 1705 +1107 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make Codecov reporting reliable again for the Dapr Python SDK by (1) configuring coverage collection so unimported files don’t artificially inflate totals and (2) fixing Codecov authentication on protected branches using GitHub OIDC.
Changes:
- Add
coverage.pyconfiguration (source,omit) inpyproject.tomlto scope measured files to the SDK packages and exclude generated proto stubs. - Grant
id-token: writeand enable Codecov OIDC uploads in the main CI workflow, failing CI onpushif the upload fails to avoid a stale base report. - Enable Codecov OIDC uploads in the tag/release workflow without blocking releases on Codecov outages.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Adds coverage.py runtime configuration to control source/omit behavior for CI coverage reporting. |
| .github/workflows/build.yaml | Enables Codecov OIDC authentication and makes main-branch coverage upload failures visible. |
| .github/workflows/build-tag.yaml | Enables Codecov OIDC authentication for tag builds without making releases depend on Codecov availability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov has been failing silently for a while now, that's why all PRs get the red check, see: https://github.com/dapr/python-sdk/actions/runs/28903767566/job/85746334110