refactor: use unwrap_or_default for optional metadata maps - #329
Merged
Conversation
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru> Signed-off-by: immanuwell <pchpr.00@list.ru>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors repeated optional-metadata handling in dapr/src/client/mod.rs by replacing a verbose HashMap::new() + if let Some(...) pattern with the idiomatic metadata.unwrap_or_default(), aligning with similar existing usage in the same module.
Changes:
- Replaces five occurrences of manual
Option<HashMap<...>>unwrapping withunwrap_or_default(). - Removes unnecessary
mutbindings where the metadata map is not mutated after initialization. - Keeps
mutonly where metadata is subsequently modified (e.g., adding"Content-Type"ininvoke_actor).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikeee
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 methods in
client/mod.rsall have the same verbose pattern for handling optional metadata:This is just a roundabout way of writing
metadata.unwrap_or_default(). Swaps all 5 instances for that. No behavior change -HashMap::default()is identical toHashMap::new().Also removes the unnecessary
muton the bindings where the map isn't modified after init (4 out of 5 cases).To reproduce the pattern before the fix: