Foundries Score#173
Merged
jacobrosenthal merged 8 commits intodarkforest-eth:masterfrom Oct 8, 2021
Merged
Conversation
| render(container) { | ||
| // Create refresh interval | ||
| this.refreshTimer = setInterval(() => { | ||
| setTimeout(() => { |
Contributor
There was a problem hiding this comment.
Curious on why this setTimout is needed here?
Contributor
Author
There was a problem hiding this comment.
It's not needed in this place, already removed it.
I'm using this method when I need to trigger some function only after DOM re-render, like here:
https://github.com/darkforest-eth/plugins/pull/173/files#diff-3c980389c28dd9c062a5a9ff0780bece3dd742b6ed985431965f7fa01e232e43R71
Maybe not the best way to do it.
Contributor
|
Nice! I tested it and worked great 👍 |
Contributor
Author
Thanks, will take take a look. |
Co-authored-by: Jacob Rosenthal <jacobrosenthal@gmail.com>
Co-authored-by: Jacob Rosenthal <jacobrosenthal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin shows total amount of foundries that can be prospected, ready to prospecting and approximate value in score.
Originally there was a plan to make numbers clickable and it should center your view to foundries one by each click but didn't have time to finish it (and that's why they are styled like links). Maybe that's something that I will update in future or someone would be interested to make it...