Skip to content

Hotfix: Screenshots posted in PR's render no fonts#479

Merged
cooper (czxtm) merged 5 commits into
mainfrom
hotfix/screenshots
Jul 5, 2026
Merged

Hotfix: Screenshots posted in PR's render no fonts#479
cooper (czxtm) merged 5 commits into
mainfrom
hotfix/screenshots

Conversation

@czxtm

@czxtm cooper (czxtm) commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

Test Plan

  • No test plan needed

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

@czxtm cooper (czxtm) marked this pull request as ready for review July 5, 2026 11:14
@czxtm
fix: bun2nix failure in CI
8f78b22
@czxtm
fix typescript errors
dd8a2cb
@czxtm
fix(ci): keep enterShell output out of the devenv env file
8817b43 
devenv's automatic `bun install` banner leaked into .devenv-ci/env,
which GITHUB_ENV rejects ("Invalid format 'bun install v1.3.13'").
Whitelist-filter the recorded lines and filter again on export so a
stale poisoned cache can't fail the job.
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Your ## Test Plan section is empty or only contains placeholder text. Describe the steps a reviewer should take to verify this change, or check No test plan needed.
⚠️

No Linear issue ID found in this PR's title, description, or branch name (expected something like ENG-123). Add one so this work is traceable in Linear, or add #no-linear to the PR description to acknowledge it's intentionally untracked.
Messages
📖

🤖 This PR touches CI / infra — reviewers please pay extra attention:

  • .github/workflows/storybook.yaml

📋 PR Overview
Lines changed 934 (+142 / -792)
Files 0 added, 44 modified, 0 deleted
Draft / WIP no
Has Test Plan no
Linear issue no
No Test Plan Needed no
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched yes
Cargo.toml touched no
Infra / CI touched yes

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 34.1% 33.5% 30.4% 28.0%

Generated by 🚫 dangerJS against 8817b43

@darkmatter

darkmatter Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎨 Storybook preview

Open Storybook preview

Updated for 8817b43

⚠️ Detected UI changes (5)

These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:

Widget/Controls/FlakeDirChooser › Multiple Candidates

Widget/Controls/FlakeDirChooser › Multiple Candidates

Widget/Controls/FlakeDirChooser › Applying

Widget/Controls/FlakeDirChooser › Applying

Widget/Drift/DriftReview › Unsummarized

Widget/Drift/DriftReview › Unsummarized

Widget/Drift/DriftReview › Summarized

Widget/Drift/DriftReview › Summarized

Widget/Drift/DriftReview › Grouped

Widget/Drift/DriftReview › Grouped

Accept UI changes

  • Click here to accept these changes

Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.

What does this do?

The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in
__snapshots__/ and flagged the difference.

Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.

Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.

arximboldi
Juanpe Bolívar (arximboldi) approved these changes Jul 5, 2026
View reviewed changes

@arximboldi Juanpe Bolívar (arximboldi) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments but LGTM when green.

Comment thread package.json
"devDependencies": {
"@types/bun": "1.3.14",
"@types/node": "25.6.0",
"bun2nix": "2.0.8",

@arximboldi Juanpe Bolívar (arximboldi) Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the pass this caused issues, because it had issues compared to the bun2nix provided by devenv. I tried though and it seems fine this time, so maybe it's ok.

Comment thread apps/native/.storybook/mocks/tauri-runtime.ts
}

async function invoke(command: string, args?: Record<string, unknown>) {
export async function invoke(command: string, args?: Record<string, unknown>) {

@arximboldi Juanpe Bolívar (arximboldi) Jul 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this caused by the linter?

@czxtm cooper (czxtm) Jul 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, the knip linter which wasnt being run regularly

@czxtm cooper (czxtm) added this pull request to the merge queue Jul 5, 2026
Merged via the queue into main with commit 208271e Jul 5, 2026
10 checks passed
@czxtm cooper (czxtm) deleted the hotfix/screenshots branch July 5, 2026 12:23
Juanpe Bolívar (arximboldi) added a commit that referenced this pull request Jul 6, 2026
@arximboldi
fix(onboarding): restore export on OnboardingStepInputs dropped in #479
2a4dbd9 
PR #479 (208271e) accidentally removed the export keyword from
OnboardingStepInputs, breaking the tsc build:

  error TS2459: Module './onboarding' declares 'OnboardingStepInputs'
  locally, but it is not exported.

Restored so onboarding.test.ts can import the type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arximboldi Juanpe Bolívar (arximboldi) arximboldi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czxtm @arximboldi