Fix critical Homebrew adoption and CLI onboarding regressions#565
Merged
Conversation
This was referenced Jul 21, 2026
Rebase the critical Cursor-bot fixes onto main: quote flake hostnames once for nix-eval Homebrew adoption, reject GitHub URLs with extra path segments before token minting, and shell-escape the privileged canonical-dir ownership script.
cooper (czxtm)
force-pushed
the
cm/critical-bug-investigation-70f3
branch
from
July 21, 2026 17:19
cbc5603 to
2071883
Compare
cooper (czxtm)
marked this pull request as ready for review
July 21, 2026 17:19
8 tasks
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
📋 PR Overview
🔬 Coverage
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto
mainand folded the remaining unique fixes from #490 (now closed):serde_json::to_stringalready quotes the hostname; the old template added a second pair and produced.#darwinConfigurations.""host"".config.homebrew.https://github.com/owner/repo/tree/mainno longer mis-parse asowner/repoviarsplit.mkdir/chownfor/etc/nix-darwinshell-escapes the username.CLI empty-model onboarding and Homebrew write-target inference already exist on
main(isInferenceConfigured/attach_existing_homebrew_write_target), so those parts of the original drafts are not duplicated here.Test plan
cargo test nix_eval_homebrew_attr_quotescargo test rejects_github_urls_with_extracargo test shell_literal_escapesmain