Skip to content

fix(promptinput): remove dead trending browse CTA - #660

Open
Farhan (fkb032) wants to merge 2 commits into
mainfrom
agent/eng-611-remove-dead-trending-cta
Open

fix(promptinput): remove dead trending browse CTA#660
Farhan (fkb032) wants to merge 2 commits into
mainfrom
agent/eng-611-remove-dead-trending-cta

Conversation

@fkb032

@fkb032 Farhan (fkb032) commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the non-functional Browse everything trending CTA from the flagged trending prompt-suggestions variant.

Why

The CTA used an empty click handler, so it promised navigation but did nothing. The app has no full trending browse route or destination; building that surface is separate product work. Removing the misleading affordance resolves ENG-611 without inventing navigation behavior.

Closes #637

Test Plan

  • bun -F native test:unit — 343 tests passed across 51 files
  • bunx oxlint apps/native/src/components/widget/promptinput/trending-feed.tsx
  • bunx tsc -p apps/native/tsconfig.json --noEmit
  • git diff --check

Biome is not runnable because the repository configuration currently cannot resolve ultracite/core; this is pre-existing and not introduced by this change.

@linear-code

linear-code Bot commented Aug 14, 2026

Copy link
Copy Markdown

ENG-611

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

📋 PR Overview

Lines changed 10 (+0 / -10)
Files 0 added, 1 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
Linear issue yes
No Test Plan Needed no
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 35.5% 35.1% 30.6% 29.4%

Generated by 🚫 dangerJS against ea9b2da

@darkmatter

darkmatter Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🎨 Storybook preview

Open Storybook preview

Updated for ea9b2da


⚠️ Detected UI changes (5)

These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:

Flows/Evolve › Playground

Flows/Evolve › Playground

Flows/Evolve › 1. Begin (idle)

Flows/Evolve › 1. Begin (idle)

Flows/Evolve › 2. Evolving (progress)

Flows/Evolve › 2. Evolving (progress)

Flows/Evolve › Evolving With Error Event

Flows/Evolve › Evolving With Error Event

Flows/Evolve › 3. Review (changes generated)

Flows/Evolve › 3. Review (changes generated)


Accept UI changes

  • Click here to accept these changes

Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.

What does this do?

The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in
__snapshots__/ and flagged the difference.

Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.

Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Browse everything trending" link does nothing

1 participant