Skip to content

synchronizeHostedView has three diverged copies of its hide/retry block #85

Description

@arzafran

WindowTerminalPortal.synchronizeHostedView (Sources/TerminalWindowPortal.swift:1186-1502) repeats a near-identical hide/retry block three times, and the copies diverged: only one of the three has the production-build recovery fallback. The two without it can leave a hosted view stuck hidden in release builds when the retry path is taken.

Fix: extract the block once with the fallback included, call it three times.


From the 2026-07-09 nuclear review (10 module reviewers + Codex cross-model pass, disprove-first). Line refs are against the reductive-audit branch (PR #81).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingnuclear-reviewFrom the 2026-07-09 whole-codebase nuclear review

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions