fix: only promote live panel titles to the workspace title - #146
Merged
Conversation
The focus-change re-derivation from #144 read panelTitles, which every panel-creation path seeds with the panel's displayTitle placeholder. A focus change could then overwrite a workspace's numbered default title (Terminal 2) with the generic placeholder (Terminal), which broke TabManagerSessionSnapshotTests.testSessionSnapshotExcludesRemoteWorkspacesFromRestore on main. Track which panels have received a real title (OSC update or session restore) in panelsWithLiveTitle and let refreshWorkspaceTitleFromFocusedPanel promote only those. Placeholder seeds still drive the in-workspace tab strip, never the sidebar title. Verified: TabManagerSessionSnapshotTests all pass locally (red before), tests_v2/test_workspace_split_title_updates.py still all green against a tagged build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the unit-test failure blocking main CI (and therefore the auto-release) since #144 merged. Workspace sidebar titles could be overwritten by the generic placeholder title a panel gets at creation, which is what broke the session-snapshot test.
Summary
panelTitles, but every panel-creation path seeds that map with the panel'sdisplayTitleplaceholder. A focus change could then replace a workspace's numbered default title ("Terminal 2") with the placeholder ("Terminal"), which is exactly whatTabManagerSessionSnapshotTests.testSessionSnapshotExcludesRemoteWorkspacesFromRestorecaught.panelsWithLiveTitleset tracks panels whose title came from a real update (OSC title or session restore).refreshWorkspaceTitleFromFocusedPanelnow promotes only those; placeholder seeds still drive the in-workspace tab strip but never the sidebar title.pruneSurfaceMetadata.Test Plan
TabManagerSessionSnapshotTestsall pass locally (the failing test reproduced deterministically before this change)tests_v2/test_workspace_split_title_updates.pystill fully green against a tagged debug build (the fix: split workspaces keep sidebar titles updated #144 behavior is preserved)