feat: complete the command palette command list - #151
Merged
Conversation
The cmd+shift+p commands palette already existed (#87 catalog, #88 controller extraction) and lists 67 commands; this closes the remaining gaps found by a scoping pass: - palette.sendFeedback and palette.reloadConfiguration contributions and handlers, wired to the same entry points as their menu/shortcut equivalents (presentFeedbackComposer, GhosttyApp.reloadConfiguration) - en + ja localization for the four new strings - README keyboard-shortcut tables gain the missing cmd+shift+p and cmd+p rows (pre-existing doc gap per the shortcut policy) - test_command_palette_modes.py asserts both commands are searchable Deliberately not added: a Quit palette command (destructive and un-palette-like; cmd+Q exists). Verified against a tagged debug build via the debug socket: commands mode opens, 'feedback' resolves palette.sendFeedback as top result, 'reload config' resolves palette.reloadConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Closes out the command palette item. The palette itself already shipped: cmd+shift+P opens a commands palette listing 67 commands, tested end to end, so most of #136 turned out to be done. This adds the two commands that were missing, documents the palette shortcuts in the README (they were absent from the shortcut tables), and extends the regression test.
Closes #136.
Summary
presentFeedbackComposer(),GhosttyApp.reloadConfiguration(source:)with a distinguishing source tag).test_command_palette_modes.pynow asserts both commands are searchable in commands mode (presence only, never invoked).Product call, veto welcome: no Quit command in the palette. Destructive, un-palette-like, and cmd+Q exists.
Adjacent cosmetic finding, not fixed here:
commandPaletteShortcutAction(for:)/commandPaletteStaticShortcutHint(for:)don't map the new commands, so their rows show no shortcut hint even though Reload Configuration has one. Harmless default-nil fallback.Test Plan
palette.sendFeedbackas the top result, "reload config" resolvespalette.reloadConfigurationpython3 -m py_compileon the edited testsimulate_typeis focus-sensitive; local runs on an in-use machine flap, which is why the testing policy routes these to the VM)