Skip to content

test: record why testCmdWClosesWindowWhenClosingLastSurfaceInLastWorkspace is skipped #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 2 commits into from
Jul 30, 2026
Merged

test: record why testCmdWClosesWindowWhenClosingLastSurfaceInLastWorkspace is skipped #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbf4c1a
test: stop skipping testCmdWClosesWindowWhenClosingLastSurfaceInLastW…
arzafran Jul 30, 2026
c40e9dd
test: record why testCmdWClosesWindow... is skipped
arzafran Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions scripts/ci-run-unit-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,32 @@ DERIVED_DATA_DIR="${PROGRAMA_DERIVED_DATA_DIR:-$HOME/Library/Developer/Xcode/Der
TEST_SCOPE="${PROGRAMA_UNIT_TEST_SCOPE:-serial}"
STATEFUL_TEST_CLASS="programaTests/AppDelegateShortcutRoutingTests"
STATEFUL_TEST_SKIP="${STATEFUL_TEST_CLASS}/testCmdWClosesWindowWhenClosingLastSurfaceInLastWorkspace"
# Skipped because it FAILS on CI, not because it flakes. This carried no reason at
# all until #221 measured it; the note below is what that run established.
#
# The test presses Cmd+W on the last surface in the last workspace and expects the
# window to close. On CI the window never closes:
#
# AppDelegateShortcutRoutingTests.swift:1463: failed - Timed out waiting for
# Cmd+W on the last surface to close the window
# AppDelegateShortcutRoutingTests.swift:1465: XCTAssertNil failed: "<NSWindow: 0x...>"
#
# Three things narrow it down:
# * NOT a timing race. #218 replaced the single fixed 0.05s spin with a 2s
# condition wait; it now waits the full two seconds and the window is still
# there. More time does not help.
# * The shortcut IS dispatched -- the XCTAssertTrue on debugHandleCustomShortcut
# just above passes. Routing works; the resulting close does not complete.
# * Headless window closing works in general. testCmdCtrlWPromptsBeforeClosing-
# Window and ...ClosesWindowAfterConfirmation both close real windows on the
# same runner and are not skipped.
#
# So it is specific to the CASCADE this test exercises: close last surface -> close
# last workspace -> close window. Whether that is a headless-only gap or a real
# product bug is undetermined; nobody has reproduced it outside CI.
#
# Do not read this skip as "the test is flaky". It is a known, reproducible failure
# of a behaviour users rely on, parked rather than diagnosed. Worth its own issue.

# Test CLASSES quarantined when PROGRAMA_UNIT_TEST_QUARANTINE is set (the
# macos-15 compat leg). Every class here builds real NSWindows and waits on async
Expand Down
Loading