refactor(settings): stop duplicating the import hint inside Settings - #233
Merged
arzafran merged 1 commit intoJul 31, 2026
Merged
Conversation
The Browser section rendered a mock of the blank-tab import hint, reusing the hint's own strings. That included its footnote, "You can always find this in Settings > Browser", displayed to someone already looking at Settings. The Choose and Refresh buttons directly below it already offer the action the mock was advertising, so the mock only added noise. The real card is unchanged in BrowserToolbarViews, and both strings are still used there. browserImportSubtitle went with it, since the mock was its only caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The Browser settings section rendered its own copy of the blank-tab import hint, reusing the hint's real strings. That included the hint's footnote, "You can always find this in Settings > Browser", shown to someone already standing in Settings.
The Choose and Refresh buttons immediately below it already offer the action the mock was advertising, so the mock was only restating them with extra chrome. The real hint card in
BrowserToolbarViewsis untouched, and both strings are still used there.Summary
browserSectionbrowserImportSubtitle, whose only caller was that mockbrowser.import.hint.titleandbrowser.import.hint.settingsFootnote, still used by the real cardWhy this is smaller than the other settings cuts
Browser turned out to have far less removable surface than Sidebar Appearance or Workspace Colors, which were pure presentation. Most of this section is functional or security-relevant, so it stays:
Show Search Suggestionsdecides whether keystrokes reach the search engine.One thing looked cuttable and was not.
Show import hint on blank browser tabsis the only path that re-enables the hint:BrowserPanelViewsets bothshowOnBlankTabs = falseanddismissed = truewhen you press "Hide Hint" in the browser toolbar, and the Settings binding is what clearsdismissedagain. Removing the toggle would have stranded anyone who ever hid the hint, with no way back short of Reset All Settings.Test plan
xcodebuild -scheme programabuilds after rebaseSources/Panels/BrowserToolbarViews.swiftNote
Stacked on #232 and based on that branch, so this diff shows only the one commit. It will retarget to
mainautomatically when #232 merges.