ci: publish debug symbols with crash artifacts - #260
Merged
Conversation
The unit-tests job already uploads sentry minidumps on failure, but not the binary that produced them — a CI-only Debug build that exists nowhere else. Two investigations of the same crash-loop had to fall back to comparing raw image-relative offsets across dumps because no symbols were available, which identifies a call site but never names it. Upload the built products (Debug carries DWARF inside the binaries) and any dSYMs alongside, plus a UUID index for matching a dump's debug_id to a file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
When a unit-test run crashes, CI uploads the sentry minidumps but not the binary that produced them — and that binary is a CI-only Debug build that exists nowhere else. Two separate investigations of the same crash-loop today had to fall back to comparing raw image-relative offsets across dumps: that proves 'these crashes share one call site' but never names the function, which is how a fix landed against a statically-inferred culprit that turned out not to be the crasher.
This uploads the built products (Debug builds carry DWARF inside the binaries) and any dSYMs next to the dumps, plus a UUID index so a dump's debug_id maps to a file without unpacking every bundle. Failure-path only, so green runs pay nothing.
Test plan