chore: sweep remaining nightly leftovers after single-lane collapse - #50
Merged
Conversation
Remove the dead nightly bundle-ID socket path, nightly icon generator and asset catalog, the -nightly tag guard in build-sign-upload.sh, and nightly wording in user-facing strings and script comments. Historical CHANGELOG and crash-context comments are intentionally left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Finishes the cleanup from #49. The nightly channel is gone, but a handful of nightly-era code paths and assets survived the collapse — a socket path keyed on the deleted nightly bundle ID, the nightly icon generator and its asset catalog, and stale "nightly" wording in a settings note and an error message. This removes them so the codebase matches the single-lane reality.
Summary
com.darkroom.programa.nightlybranch fromSocketControlSettings.defaultSocketPath(dead: that bundle ID can no longer exist)scripts/generate_nightly_icon.pyandAssets.xcassets/AppIcon-Nightly.appiconset/(referenced nowhere else)scripts/icon-gen/finalize.shand the-nightlytag guard inscripts/build-sign-upload.sh(tags can never be*-nightlynow)settings.automation.socketOverrides.notestring ("stable/nightly builds" → "release builds") in source +Localizable.xcstrings, and theWorkspace.swiftremote-daemon error/commentbuild_remote_daemon_release_assets.shcommentTabManager.swiftarm64-Nightly crash-context comments, Cursor/Zed Nightly third-party app paths, and the debug-only long-version pillTest Plan
xcodebuild -scheme programa)bash -non both touched shell scriptsLocalizable.xcstringsstill valid JSONgit grep -i nightlyin Sources/scripts/Resources shows only the intentionally-kept references