refactor: extract browser data-import subsystem out of BrowserPanel.swift - #57
Merged
Merged
Conversation
…wift BrowserPanel.swift carried ~3,800 lines (35% of the file) of self-contained browser-import machinery — scope/engine/profile types, InstalledBrowserDetector, plan/outcome models, the Chromium cookie decryptor, BrowserDataImporter, and BrowserDataImportCoordinator with its wizard window controller. None of it references the BrowserPanel class. Pure move, no logic changes: - Sources/Panels/BrowserDataImport.swift — the entire import subsystem - BrowserPanel.swift shrinks 10,401 -> 6,585 lines - dedupedCanonicalURLs (fileprivate helper used only by the import code) moves with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Moves the browser data-import subsystem (~3,800 lines: importer engine, cookie decryptor, plan/outcome models, wizard coordinator) out of
BrowserPanel.swiftintoSources/Panels/BrowserDataImport.swift.BrowserPanel.swiftdrops from 10,401 to 6,585 lines.Nuclear-review finding N6/WP2: the block has zero references to the
BrowserPanelclass — it was just parked in the same file.Summary
dedupedCanonicalURLs(fileprivate helper used only by import code) moves with themproject.pbxprojTest Plan