refactor: split TabManager into per-concern extension files - #59
Merged
Conversation
TabManager.swift hosted git-metadata polling, browser-panel operations, split operations, and session persistence alongside core lifecycle in one 5,968-line class. The four clusters move verbatim to same-type extension files (5,968 -> 5,086 lines in the core file); stored properties and deinit stay in the class body. Visibility widened from private to internal only where the move split a same-file reference. Nuclear-review WP5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Splits the 5,968-line
TabManagerclass into focused files so working on git polling, browser panels, splits, or session persistence stops recompiling (and re-reading) everything else. Core lifecycle/selection stays inTabManager.swift(now 5,086 lines).Nuclear-review finding WP5. File surgery by one agent, verified and finished by a second pass.
Summary
TabManager+GitMetadataPolling.swift(233) — Agent PID sweep + git metadata timers (orig. 954–1177)TabManager+Browser.swift(268) — browser panel operations (orig. 4227–4486)TabManager+Splits.swift(246) — split creation + backwards-compat split ops (orig. 3906–3947, 4034–4226)TabManager+SessionPersistence.swift(167) — was already a standalone extension at end of file; clean liftisWorkspaceCycleHotbecomesinternal(set)Test Plan