docs: add the claims-updated checkbox to the PR template - #412
Merged
Conversation
The AGENTS.md convention landed without it: macOS treats the lowercase and uppercase template filenames as one file, but only the uppercase path is tracked, so staging the lowercase name added nothing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #411, which landed the AGENTS.md conventions but silently dropped this one line.
macOS treats
pull_request_template.mdandPULL_REQUEST_TEMPLATE.mdas the same file, but git tracks only the uppercase path. Editing the lowercase name changed the file on disk while staging that path added nothing, so the commit went through green with the change missing.Fittingly, this is the convention it was implementing: ship the claim with the fix. The claim shipped, the fix did not.
Test Plan
git show HEAD:.github/PULL_REQUEST_TEMPLATE.mdends with the new checkbox