Skip to content

Overhaul README.md and add python venv - #44

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
da-phil:pl/readme_overhaul_and_add_python_requirements
Sep 5, 2026
Merged

Overhaul README.md and add python venv#44
TurboGit merged 1 commit into
darktable-org:masterfrom
da-phil:pl/readme_overhaul_and_add_python_requirements

Conversation

@da-phil

@da-phil da-phil commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The README.md file was in a stale state and contained out-of-date content which was updated. Also, previously the run script silently assumes that the necessary python dependencies are available in the executing shell. Now all python requirements are collected in a requirements.txt file and a virtual environment is automatically created and activated at the beginning of the run script. This ensures a higher reproducibility and convenience when running the script.

This PR supersedes #40.

The README.md file was in a stale state and contained out-of-date content which was updated.
Also, previously the run script silently assumes that the necessary python dependencies are available in the executing shell.
Now all python requirements are collected in a requirements.txt file and a virtual environment is automatically created and activated  at the beginning of the run script.
This ensures a higher reproducibility and convenience when running the script.

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit f126a06 into darktable-org:master Sep 5, 2026
@da-phil
da-phil deleted the pl/readme_overhaul_and_add_python_requirements branch September 5, 2026 20:19
@da-phil da-phil mentioned this pull request Sep 5, 2026
@da-phil

da-phil commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

@TurboGit shall we bump the test submodule in the darktable repo in the meantime?

@TurboGit

TurboGit commented Sep 6, 2026

Copy link
Copy Markdown
Member

Yes, will do. I have a bad flu or covid so very slow at the moment.

@da-phil

da-phil commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Yes, will do. I have a bad flu or covid so very slow at the moment.

I'm sorry to hear that, get well soon and don't worry about darktable for the time being, we need a healthy maintainer ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants