Clipping changes.#159
Conversation
…eset itself. (plugins/darkroom/clipping/aspect_flipped) * Change the saved custom_aspect to be a string with the actual custom aspect. This is so the user will see what he/she entered instead of a computed value. * When the user enters an aspect ratio of his/her own, actually save it too. (plugins/darkroom/clipping/custom_aspect) * Handle the saved presets better when starting up.
|
For custom aspect ratios, it actually saves it (it didn't before, so you'd end up with 1.5:1 when coming back into develop mode because that is the installed default). It also saves it in the form that the user typed it in, so it can shown back the same way later on, instead of {fraction}:1. #9151: http://darktable.org/redmine/issues/9151 |
ghost
assigned
|
Pascal, I am assigning the PR to you since you worked in that area and said you would look at it with your changes... if you don't want to look into it, please deassign yourself and i'll deal with it thx |
|
Sure. Richard said on the mailing-list that he was working on an updated version IIRC. Richard? |
|
oh, I must have missed that... |
|
Yup. It'll be a couple of days before you see the rest happening, though. |
|
still working on this ? should I wait for an update or is it good as is ? |
|
[change of mind] please merge this pull if you see it fit, as it's a unit of its own, independent enough from what I'm working on now. |
|
ok, I wasn't able to test the code itself because the aspect in c&r seems to be very broken in multiple ways "image" ratio is not selected (3:2) on new images, though it seems tocome back randomly the aspect ratio seems to be carried over from image to image when switching... i'm sorry for your PR but i'd rather merge it on a solid basis and this is currently not the case. don't worry we didn't forget you, though |
|
Ok, the C&R module was really buggy, and @AlicVB reimplemented a big part of it in his branch. Fixing the bugs meant implementing what this patch was doing but in a different way. So your feature request was fulfilled, but not using your patch thx for the code anyway |
|
Yup, I noticed his fixes, and I like. I'll simply delete this branch. |
4 participants
itself. (plugins/darkroom/clipping/aspect_flipped)
aspect. This is so the user will see what he/she entered instead of a
computed value.
too. (plugins/darkroom/clipping/custom_aspect)
Fixes #9151, #9143