Skip to content

fix jerky scrolling when using trackpad#16538

Merged
TurboGit merged 2 commits into
darktable-org:masterfrom
zisoft:fix-jerky-scrolling
Mar 29, 2024
Merged

fix jerky scrolling when using trackpad#16538
TurboGit merged 2 commits into
darktable-org:masterfrom
zisoft:fix-jerky-scrolling

Conversation

@zisoft
Copy link
Copy Markdown
Collaborator

@zisoft zisoft commented Mar 29, 2024

When scrolling on a trackpad using a two-finger swipe only the vertical component of the event should be used for calculating the scroll delta.

dt_gui_get_scroll_unit_delta() adds delta_x and delta_y which can lead to unexpected jerky scrolling when swiping diagonally.

fixes #16537

zisoft added 2 commits March 29, 2024 19:12
When scrolling on a trackpad using a two-finger swipe only the vertical
component of the event should be used for calculating the scroll delta.

`dt_gui_get_scroll_unit_delta()` adds `delta_x` and `delta_y` which can
lead to unexpected jerky scrolling when swiping diagonally.

fixes darktable-org#16537
@TurboGit TurboGit added this to the 4.8 milestone Mar 29, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. labels Mar 29, 2024
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit merged commit 98a61f2 into darktable-org:master Mar 29, 2024
@zisoft zisoft deleted the fix-jerky-scrolling branch March 30, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling the library is jerky and erratic when using the two-finger-swipe gesture

2 participants