Bundle lua-scripts into the darktable release #19899
Draft
+27
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpferguson
added
feature: enhancement
Member
Author
|
Here's the correct script_manager file EDIT: How to test this
If you want to test a downloaded copy of the scripts repository
That's where development is at this point. Succeeding versions of script_manager will enable more functionality |
Added a line to start tools/script_manager to handle
figuring out where scripts are as well as starting and
stopping them
external/CMakeLists.txt - Added step to install external/lua-scripts
into <install dir>/share/darktable/lua-scripts
lua/configuration.h - Bumped API to 9.7.0 since this is a change to
how the scripts are handled. This change
doesn't break anything, so it didn't require
changing the major version.
lua/init.c - removed the step that runs the user luarc file. This
is now handled by script_manager. Added the <install dir>/
share/darktable/lua-scripts to the lua search path.
The final part to make this work is a modified version of script_manager,
which would require updating the lua-scripts repository and then updating
the external library. I'll hold off until 5.4(.1?) is released. In the
meantime I'll include a modified version in the PR for testing.
headless because starting the scripts when darktable
is headless results in a hang.
Member
Author
|
Status update:
|
lua/init.c - code cleanup
wpferguson
force-pushed
the
bundle_lua_scripts
branch
from
ee32ec2 to
dee343a
Compare
|
Tested with the corresponding lua-scripts version, the system-wide lua-scripts work as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables bundling the lua-scripts with the darktable release, removing the last barrier to entry for using the scripts.
The bundled scripts are the choice of last resort, so if the user already has the lua-scripts installed the user version takes priority.
The scripts can also run in a "hybrid" mode where the bundled scripts are used and selected scripts can be added by placing them in the users lua directory.
This PR is a work in progress. One final piece is needed to make it work and that is a modified script_manager. That will be merged separately into the lua-scripts repository and then accessed through the external/lua-scripts submodule.
For testing I'm included a modified script_manager that needs to replace /share/darktable/lua-scripts/tools/script_manager.lua