Skip to content

when all midi devices disabled, don't initialise portmidi#20101

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
dterrahe:disable_midi
Feb 7, 2026
Merged

when all midi devices disabled, don't initialise portmidi#20101
TurboGit merged 1 commit intodarktable-org:masterfrom
dterrahe:disable_midi

Conversation

@dterrahe
Copy link
Copy Markdown
Contributor

@dterrahe dterrahe commented Jan 7, 2026

@dterrahe dterrahe added priority: low core features work as expected, only secondary/optional features don't difficulty: trivial some changes in a couple of functions scope: hardware support dealing with drivers and external devices: GPU, printers labels Jan 7, 2026
@TurboGit
Copy link
Copy Markdown
Member

TurboGit commented Jan 7, 2026

@dterrahe : This would qualify for 5.4.1, but there is a string changes. Can you avoid it for 5.4.1? Maybe split this PR in 2 commits and I'll cherry pick only one for 5.4.1. Would that work?

@dterrahe dterrahe added this to the 5.6 milestone Jan 7, 2026
@dterrahe
Copy link
Copy Markdown
Contributor Author

dterrahe commented Jan 7, 2026

No urgency. This is just a minor speedup at start. Unless we get real reports about crashes or other interference, which I haven't seen.

@TurboGit
Copy link
Copy Markdown
Member

TurboGit commented Jan 7, 2026

Ah, ok. I've indeed miss interpreted this has being more important. Thanks for the clarification.

Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 6690177 into darktable-org:master Feb 7, 2026
5 checks passed
@dterrahe dterrahe deleted the disable_midi branch February 7, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: trivial some changes in a couple of functions priority: low core features work as expected, only secondary/optional features don't release notes: pending scope: hardware support dealing with drivers and external devices: GPU, printers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants