Adds a configuration option to disable auto-centering of the filmstirp#20430
Adds a configuration option to disable auto-centering of the filmstirp#20430TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
a931e18 to
712d4b6
Compare
|
Are there cases where it's valuable to have the auto centering on? If there is, would a toggle or shortcut make more sense so that you could enable and disable as needed? |
|
@wpferguson sorry, for some reason I didn't get notification emails for this PR. Sure, I am happy to add both if you agree that it's good to have. The minimalistic PR was meant just to test the water. |
|
When I asked the question, it was truly just a question. I don't use filmstrip, so I don't know the answer. Maybe ask it on pixls.us? Although lately it seems that any question there turns into a long conversation really quick. |
|
Sounds good, grab your popcorn! 😝 https://discuss.pixls.us/t/pr-discussion-disabling-film-strip-autocentering/56685?u=masterpiga |
|
🤣 |
TurboGit
left a comment
There was a problem hiding this comment.
Thanks!
This is currently an hidden pref, so really no problem and I could have merged this sooner. Now if needed I'm ok for an entry in the preferences if really needed. I'm not sure a new welcome screen is a good idea as this sounds like a very minor point, but we can discuss.
Auto-centering can be problematic, especially when working on a sequence of similar looking images.
The filmstrip moves back and forth and one loses track of where the previous image was.
This only adds a hidden config option, i.e., no changes to the preferences UI.
I would be happy to add that as well if this PR is accepted and the addition is deemed worthy.