Replace segmentation model type heuristic with arch field#20515
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Mar 14, 2026
Merged
Replace segmentation model type heuristic with arch field#20515TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
TurboGit
reviewed
Mar 14, 2026
Member
|
In the new models created I don't have the arch in config.json: And then creating the mask fails, the message on the console:
If I add manually the arch into config.json all this working. |
Contributor
Author
|
I see, missed to add in conversion script. Will update shortly |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archfield todt_ai_model_info_t(backend layer), parsed from modelconfig.jsonsegmentation.cwith explicit arch lookup ("sam2"or"segnext")"arch"in theirconfig.json— missing arch fails with a clear error messageMotivation
The previous approach detected SAM vs SegNext by counting decoder outputs (3+ = SAM, 1 = SegNext). This is fragile and would break when adding new model architectures with different output counts. Using an explicit
archfield makes model type detection reliable and extensible.