[AI] Fix disk cache load with dynamic encoder output shapes#20601
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Mar 20, 2026
Merged
[AI] Fix disk cache load with dynamic encoder output shapes#20601TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The disk cache for object mask encoder embeddings always fails on the first load after restarting darktable. The second load of the same image (within the same session) works fine.
Root cause
When the model loads with
ORT_DISABLE_ALL(fallback for ORT versions where optimization crashes), encoder output shapes are reported as dynamic (-1). The cache file stores the resolved shapes from a previous inference (e.g.[1, 32, 256, 256]), but on load the validation compares them against the model's unresolved shapes ([-1, 32, -1, -1]) and rejects the mismatch.After re-encoding,
ctx->enc_shapesgets updated with resolved values, so subsequent cache loads in the same session succeed.Fix
<= 0)ctx->enc_shapesafter a successful load, so the decoder gets valid shapes instead of-1