[AI] Replace edge refinement with guided filter in object mask#20622
Merged
TurboGit merged 3 commits intodarktable-org:masterfrom Mar 24, 2026
Merged
[AI] Replace edge refinement with guided filter in object mask#20622TurboGit merged 3 commits intodarktable-org:masterfrom
TurboGit merged 3 commits intodarktable-org:masterfrom
Conversation
5c047e3 to
cbe366d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Edge refinement
The previous approach computed Scharr gradients and modulated the binarization threshold near edges. The new approach uses
guided_filter()fromcommon/guided_filter.h(same filter used by blend.c for drawn mask feathering). It smooths the SAM mask in flat regions while preserving sharp transitions at image edges, producing cleaner object boundaries.Two configurable parameters (in
darktablerc):guided_radius(0-20, default 5): filter window size. 0 disables the filterguided_eps(0.001-1.0, default 0.01): edge sensitivity. smaller = sharper edgesRender resolution
The render resolution is now configurable via
render_size(default 1024, minimum 1024, no upper limit). The SAM encoder always works at 1024px internally, but higher render resolution gives the guided filter and vectorizer more pixels to work with, improving edge accuracy at the cost of processing time.Users with powerful hardware can increase this for better results: