Markesteijn and VNG demosaic fixes#20631
Open
jenshannoschwalm wants to merge 2 commits intodarktable-org:masterfrom
Open
Markesteijn and VNG demosaic fixes#20631jenshannoschwalm wants to merge 2 commits intodarktable-org:masterfrom
jenshannoschwalm wants to merge 2 commits intodarktable-org:masterfrom
Conversation
1. The CPU code deserves the better border calculation as we do for OpenCL since very long. There is a small performance penalty but with clearly better results. I was likely just overseen for many years. 2. The VNG linear interpolation got modifications to handle borders. 3. Fix subtle differences between OpenCL and CPU for low levels.
1. Fix OpenCL VNG full interpolation, we must not touch the outermost 2 pixels, they have been interpolated already in the linear phase. 2. Ensure identical results for VNG initial 1-photosite borders. 3. Fix VNG final green mixing for bayer4 sensors. Do this at the end of processing for both CPU and GPU code. 4. Fix some maths leading to different results OpenCL vs CPU 5. Added tooltip why VNG4 is still a valuable demosaicer.
Member
|
All tests have less or equal differences, that's great. There is one exception where the CPU vs GPU diff was below 17000 and is now > 38000. |
Collaborator
Author
|
Yes i see that too.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markesteijn demosaicer fixes
Various VNG demosaicer fixes
@TurboGit this definitely changes expected output for all xtrans related tests as we change the border maths. (0065 0066 0068 0100 0145 0146 0165 0173) All related tests show less differences btw.
For these parts all is good to me so ready to be merged.
Pending work on demosaicers: Some deduplication of PPG/RCD/LMMSE border code, still too large GPU/CPU differences for green averaging for some reason.
afterthat pending work it will be the work on tests with large diffs ...