[AI] Add TIFFTAG_PREVIEWCOLORSPACE fallback for libtiff < 4.6#20933
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom May 5, 2026
Merged
[AI] Add TIFFTAG_PREVIEWCOLORSPACE fallback for libtiff < 4.6#20933TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
Closed
1 task
TurboGit
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20932
imageio_dng.cfails to compile on libtiff < 4.6 (Debian 12, Ubuntu 22.04 / 24.04) becauseTIFFTAG_PREVIEWCOLORSPACEwas only added in libtiff 4.6.Adds a one-line
#ifndeffallback that defines the macro to its DNG-spec value (50970) when libtiff didn't.Verified against libtiff 4.3.0 source – it's the only DNG tag darktable uses that's missing in pre-4.6; everything else (
DNGVERSION,COLORMATRIX1,BLACKLEVEL,ACTIVEAREA, …) has been there since 4.0.