Make gui->reset an atomic operation.#21026
Merged
Merged
Conversation
TurboGit
added
bugfix
This was referenced May 14, 2026
TurboGit
force-pushed
the
po/gui-reset
branch
2 times, most recently
from
447ac45 to
1603ca8
Compare
Collaborator
|
Heavy stuff :-) |
Also ensure that a check for atomic value and increment is atomic. That is, the following control is not good as could be interrupted between the check and the setting: if(darktable.gui->reset) return; ++darktable.gui->reset; Upadte the developer documentation.
Collaborator
|
Quite a bit of work there. I've only spot-checked the code, but looks good. |
Member
Author
|
Merging now, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ensure that a check for atomic value and increment is atomic. That is, the following control is not good as could be interrupted between the check and the setting:
if(darktable.gui->reset) return;
++darktable.gui->reset;
Upadte the developer documentation.