AI subsystem: review fixes#21144
Merged
Merged
Conversation
TurboGit
requested changes
May 26, 2026
Member
TurboGit
left a comment
There was a problem hiding this comment.
Some style comments, and a better way to create a temp file.
Collaborator
Author
|
@TurboGit : Fixed according to the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran a multi-pass AI-assisted review over the new AI subsystem code – headers, core implementation, domain logic, UI layer, Lua bindings, and a few adjacent non-AI files. I traced every claim line-by-line against the actual code before touching anything, and roughly one in five survived that check. The rest is in this PR.
Everything here is small and preventive. No new features, no behaviour rewrites, no refactors beyond the minimum needed for a specific bug. Each finding is its own commit so anything can be cherry-picked or reverted on its own.
What's in here
.dtmodelinstall, segmentation disk cache). A crash mid-write no longer leaves a half-written file that confuses the next run.dt_ai_run,TIFFWriteScanline, decoder warmup.abort()the process during execution-provider init on a broken CUDA or ROCm stack.dt_ai_registry_tis now opaque to external callers, the unusedep_flagsparameter is gone,dt_ai_snapshot_conf_stateis idempotent.Risk
Low. Most fixes are one-line guards or unlink-on-failure additions. The largest single change is the opaque-registry refactor (
f4bd660574) – a mechanical rename that keeps the same semantics under the same lock as before.