Skip to content

Introduce database maintenance into purging scripts#4303

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
johnny-bit:sqlite_database_maintenance
Feb 16, 2020
Merged

Introduce database maintenance into purging scripts#4303
TurboGit merged 1 commit intodarktable-org:masterfrom
johnny-bit:sqlite_database_maintenance

Conversation

@johnny-bit
Copy link
Copy Markdown
Member

In discuss.pixls.us thread, user gadolf suggested having periodic database maintenance somewhere in darktable.

I figured out that 1st place to do so, would be in purging scripts.
Reasoning is simple: VACUUM surelly helps with database overgrowth, and where's the better place if not right after purging unnecessary entries?

ANALYZE in those cases theorecitally should write stats tables for query scheduler and increase overall performance (although I believe the change seen will be minimal).

@TurboGit TurboGit self-requested a review February 16, 2020 18:28
@TurboGit TurboGit self-assigned this Feb 16, 2020
@TurboGit TurboGit added difficulty: trivial some changes in a couple of functions feature: enhancement current features to improve scope: performance doing everything the same but faster understood: clear devs have a complete bug report with all the relevant info to start fixing labels Feb 16, 2020
@TurboGit TurboGit added this to the 3.2 milestone Feb 16, 2020
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@TurboGit TurboGit merged commit 8230fd8 into darktable-org:master Feb 16, 2020
@johnny-bit johnny-bit deleted the sqlite_database_maintenance branch February 16, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: trivial some changes in a couple of functions feature: enhancement current features to improve scope: performance doing everything the same but faster understood: clear devs have a complete bug report with all the relevant info to start fixing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants