Skip to content

make values in color picker selectable for copy/paste#9848

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
Mark-64:make_colorpicker_labels_selectable
Aug 21, 2021
Merged

make values in color picker selectable for copy/paste#9848
TurboGit merged 1 commit intodarktable-org:masterfrom
Mark-64:make_colorpicker_labels_selectable

Conversation

@Mark-64
Copy link
Copy Markdown
Contributor

@Mark-64 Mark-64 commented Aug 21, 2021

This simple PR fixes #9836, by making the color values shown in global color picker selectable, for using them in copy/paste operation with other tools.
Besides, it introduces Hex as additional color mode.

Examples

immagine

immagine

I am aware that there is a heavy ongoing rework of the color picker by @dtorop and, if this PR interferes, it can wait no problem

@johnny-bit johnny-bit added feature: enhancement current features to improve scope: UI user interface and interactions labels Aug 21, 2021
@johnny-bit johnny-bit added this to the 3.8 milestone Aug 21, 2021
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks.

@TurboGit TurboGit merged commit 58361b5 into darktable-org:master Aug 21, 2021
@TurboGit TurboGit added documentation: pending a documentation work is required release notes: pending labels Aug 21, 2021
@elstoc elstoc added documentation: complete needed documentation is merged in dtdocs and removed documentation: pending a documentation work is required labels Aug 22, 2021
@todd-prior
Copy link
Copy Markdown

todd-prior commented Aug 23, 2021

I can't remember if it was like this before or this is a product of the rewrites...the display of color values on hover is cut off. I think it used to show all the possible values?? I can't recall....see screenshot...

image
EDIT I am currently on 3.7.0+799~gd5556228e on Win10

EDIT2...This is only the case if the large patch view is enabled....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation: complete needed documentation is merged in dtdocs feature: enhancement current features to improve scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small request to be able to copy values from color picker to the clipboard.

5 participants