Skip to content

fix official/selection_to_pdf translatable strings #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpferguson merged 1 commit into from
Apr 20, 2026
Merged

fix official/selection_to_pdf translatable strings #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions official/selection_to_pdf.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ local script_data = {}

script_data.metadata = {
name = _("selection to PDF"),
purpose = _("generate a pdf file of selected images"),
purpose = _("generate a PDF file of selected images"),
author = "Jérémy Rosen & Pascal Obry",
help = "https://docs.darktable.org/lua/stable/lua.scripts.manual/scripts/official/selection_to_pdf"
}
Expand All @@ -66,8 +66,8 @@ script_data.show = nil -- only required for libs since the destroy_method only h

dt.preferences.register
("selection_to_pdf","Open with","string",
_("a pdf viewer"),
_("can be an absolute pathname or the tool may be in the PATH\nif not specified the system default will be used to open the pdf"),
_("a PDF viewer"),
_("can be an absolute pathname or the tool may be in the PATH\nif not specified the system default will be used to open the PDF"),
"")

local title_widget = dt.new_widget("entry") {
Expand Down Expand Up @@ -134,7 +134,7 @@ local function destroy()
dt.print_log("done destroying")
end

dt.register_storage("export_pdf", _("export thumbnails to pdf"),
dt.register_storage("export_pdf", _("export thumbnails to PDF"),
nil,
function(storage,image_table)
local my_title = title_widget.text
Expand Down Expand Up @@ -200,7 +200,7 @@ dt.register_storage("export_pdf", _("export thumbnails to pdf"),
command = command .. " " .. pdffile
local result = dt.control.execute(command)
if result ~= 0 then
dt.print(_("problem running pdf viewer")) -- this one is probably usefull to the user
dt.print(_("problem running PDF viewer")) -- this one is probably usefull to the user
error("Problem running "..command)
end

Expand Down