Panasonic LUMIX L10 support#976
Conversation
| </Camera> | ||
| <Camera make="Panasonic" model="DC-L10" supported="unknown-no-samples"> | ||
| <Camera make="Panasonic" model="DC-L10"> | ||
| <Crop x="4" y="4" width="-4" height="-4"/> |
There was a problem hiding this comment.
Crop should be 0 everywhere, the entire raw image pixel array is usable in all aspect ratios for this model.
At least for the moment
RawSpeed does NOT…
crop the image to the same sizes as manufactures, but supplies biggest possible images.
(There are of course some exceptions to the "rule" when absolutely required.)
There was a problem hiding this comment.
Fixed.
Just for my understanding, in which cases we are adding crop information?
There was a problem hiding this comment.
When there are real junk or black area pixels to actually crop (e.g. older Panasonics, older Sony raw formats, etc.)
There are also some cases/exceptions where we removed the <Crop> property altogether to let the vendor/metadata crop actually take over (e.g. done for recent Fujifilms because the "junk" area differs in regular vs "sport" 1.25x crop modes and we decided to not introduce new "modes" in source nor cameras.xml; it was also necessary for some particular Panasonics IIRC...)
So it's a case-by-case basis really, therefore every raw mode of any model needs to be checked manually... (I use rstest tool or LibRaw's unprocessed_raw to dump and inspect the entire raw array, if it is decodable of course...)
2 participants
Sample images are provided in darktable-org/darktable#21465
I also uploaded another set of my sample images of all crops to https://raw.pixls.us.
From my sample set I created records in
cameras.xml. Tested in darktable master branch - all images opened in darkroom without any problem.