feat(web): edit and number chat annotations - #2
Closed
darox wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on pingdotgg/t3code#5224. This PR contains exactly one follow-up commit; review the changes relative to
codex/chat-annotations-desktop.What Changed
Adds editing and numbered indicators to the response-text annotations introduced in pingdotgg#5224.
Users can now:
Why
The base annotation flow makes it possible to attach selected response text, but pending annotations are difficult to locate again and cannot be corrected without removing and recreating them. Numbered markers make the relationship between the composer summary and assistant response obvious, while the editor keeps small comment changes fast.
UI Changes
Before
The base flow exposes selection and composer actions, but does not show numbered source markers or an edit affordance.
After
Selecting response text still opens the existing Add to chat action.
Pending annotations now show numbered markers beside the source response and a matching composer summary.
Clicking a marker highlights the source text and opens an editor for the comment.
Multiple annotations receive stable sequential numbers and remain visible alongside the prompt.
After sending, the conversation keeps the compact annotation summary without exposing serialized markup.
Validation
./node_modules/.bin/vp test run apps/web/src/chatSelectionAnnotation.test.ts apps/web/src/components/ChatView.logic.test.ts apps/web/src/components/chat/MessagesTimeline.test.tsx apps/web/src/composerDraftStore.test.ts apps/web/src/proposedPlan.test.ts(158 passed)./node_modules/.bin/vp run --filter @t3tools/web typecheck./node_modules/.bin/vp run --filter @t3tools/shared typecheckgit diff --checkChecklist
Model: OpenAI Codex · Harness: Codex desktop