This repository was archived by the owner on Sep 12, 2019. It is now read-only.
List error codes#35
Merged
Merged
Conversation
Contributor
|
LGTM Can you also (in this PR or another) make a function to look up the error code objects by error code name? In the dart analyzer they made a hashmap of codes to objects, and on lookup it lazily fills the map based on the list |
MichaelRFairhurst
approved these changes
Apr 18, 2017
Contributor
Author
|
I added that part to the angular_analyzer_plugin. Do you think we should condense the logic into angular_analyzer_plugin or keep it separate? Refer to dart-archive/angular_analyzer_plugin#276 for the part that improves the lazy loading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a list of error codes - to be used by angular-analyzer-plugin.