Fixes #2930. Fix failing Stream tests. #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good to me. @lrhn, you know this better than anyone, do you have further comments? |
eernstg
approved these changes
Oct 11, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 18, 2024
2024-10-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2938. Remove string literals identity check (dart-lang/co19#2939) 2024-10-17 sgrekhov22@gmail.com dart-lang/co19#2933. Add MultiStreamController tests. Part 2. (dart-lang/co19#2937) 2024-10-17 sgrekhov22@gmail.com dart-lang/co19#2930. Add MultiStreamController tests. Part 1. (dart-lang/co19#2936) 2024-10-16 sgrekhov22@gmail.com dart-lang/co19#2933. Add tests for `Stream.multi` constructor. (dart-lang/co19#2935) 2024-10-15 sgrekhov22@gmail.com dart-lang/co19#2933. Add tests for `Stream.error` and `Stream.value` constructors. (dart-lang/co19#2934) 2024-10-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2930. Fix failing Stream tests. (dart-lang/co19#2932) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ib7d939f6edaf72a344e75c473e564923d3c811cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390702 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes dart-lang/sdk#49264. Updated tests use
Stream.mapto check that the subscription was cancelled and there are no new events. The updated tests pass.