Skip to content

Conversation

@sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lrhn, it would be great if you could take a look as well.

@eernstg eernstg requested a review from lrhn October 14, 2024 15:48
@sgrekhov
Copy link
Contributor Author

Thank you! Updated. PTAL.

@sgrekhov sgrekhov requested review from eernstg and lrhn October 15, 2024 14:41
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 1f46397 into dart-lang:master Oct 15, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 18, 2024
2024-10-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2938. Remove string literals identity check (dart-lang/co19#2939)
2024-10-17 sgrekhov22@gmail.com dart-lang/co19#2933. Add MultiStreamController tests. Part 2. (dart-lang/co19#2937)
2024-10-17 sgrekhov22@gmail.com dart-lang/co19#2930. Add MultiStreamController tests. Part 1. (dart-lang/co19#2936)
2024-10-16 sgrekhov22@gmail.com dart-lang/co19#2933. Add tests for `Stream.multi` constructor. (dart-lang/co19#2935)
2024-10-15 sgrekhov22@gmail.com dart-lang/co19#2933. Add tests for `Stream.error` and `Stream.value` constructors. (dart-lang/co19#2934)
2024-10-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2930. Fix failing Stream tests. (dart-lang/co19#2932)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ib7d939f6edaf72a344e75c473e564923d3c811cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390702
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants