#3315. Move tests for formal parameters to primary-constructors
#3403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Nov 19, 2025
| // [analyzer] unspecified | ||
| // [cfe] unspecified | ||
|
|
||
| class C4({required covariant final String x}) {} |
Member
There was a problem hiding this comment.
It looks like these tests are still valid, but perhaps they were moved to LanguageFeatures/Primary-constructors/static_processing_A08_t01.dart, so they are still included?
Member
There was a problem hiding this comment.
In that case it's just Github diff which isn't smart enough to see the connection, showing this file as deleted and LanguageFeatures/Primary-constructors/static_processing_A08_t01.dart as new.
Member
|
I think it may be helpful to create a pure "move/rename PR" rather than a PR that both moves/renames and modifies some files. This would make it easy to see that nothing other than renaming and moving of files is going on. The current PR is a little bit harder to read because Github diff fails to see that a particular file occurs in the PR because some other file was moved and modified, so it looks like lost coverage plus a completely new test. |
Contributor
Author
|
Ok, thank you. Sorry for inconvinience. I'll move all other files in the next PR. |
Member
|
Sounds good, thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 24, 2025
2025-11-21 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for the body of the primary constructor (dart-lang/co19#3411) 2025-11-21 sgrekhov22@gmail.com Fixes dart-lang/co19#3409. Add missing expected warnings (dart-lang/co19#3410) 2025-11-20 sgrekhov22@gmail.com dart-lang/co19#3315. Update tests for formal parameters. Part 4. (dart-lang/co19#3407) 2025-11-20 sgrekhov22@gmail.com dart-lang/co19#3315. Update tests for formal parameters. Part 5. (dart-lang/co19#3408) 2025-11-20 sgrekhov22@gmail.com dart-lang/co19#3315. Update tests for formal parameters. Part 2. (dart-lang/co19#3405) 2025-11-20 sgrekhov22@gmail.com dart-lang/co19#3315. Update tests for formal parameters. Part 3. (dart-lang/co19#3406) 2025-11-19 sgrekhov22@gmail.com dart-lang/co19#3315. Move primary constructors files to `Primary-constructors` (dart-lang/co19#3404) 2025-11-19 sgrekhov22@gmail.com dart-lang/co19#3315. Move tests for formal parameters to `primary-constructors` (dart-lang/co19#3403) 2025-11-19 sgrekhov22@gmail.com dart-lang/co19#3315. Rename experimental flag to `primary-constructors` (dart-lang/co19#3402) 2025-11-19 sgrekhov22@gmail.com dart-lang/co19#3315. Update VM tests for primary constructors (dart-lang/co19#3401) 2025-11-18 sgrekhov22@gmail.com dart-lang/co19#3315. Move/add mixins and generative constructors tests to `Primary-constructors`. (dart-lang/co19#3394) 2025-11-18 sgrekhov22@gmail.com dart-lang/co19#3315. Move name conflicts tests for constructors to `Primary-constructors` (dart-lang/co19#3397) 2025-11-18 sgrekhov22@gmail.com dart-lang/co19#2694. Replace `unspecified` by real lint name (dart-lang/co19#3400) 2025-11-18 sgrekhov22@gmail.com dart-lang/co19#2559. Update `augmenting_constructors_A01_*` tests (dart-lang/co19#3388) 2025-11-17 sgrekhov22@gmail.com dart-lang/co19#3315. Move parameters scope tests to `Primary-constructors` (dart-lang/co19#3398) 2025-11-17 sgrekhov22@gmail.com dart-lang/co19#2694. Remove obsolete `null-aware-elements` experimental flag (dart-lang/co19#3399) 2025-11-14 sgrekhov22@gmail.com dart-lang/co19#3315. Update and move extension types tests to `Primary-constructors` (dart-lang/co19#3396) 2025-11-14 sgrekhov22@gmail.com dart-lang/co19#3315. Add test checking the special rule for factory constructors (dart-lang/co19#3395) 2025-11-14 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for `new()` and `factory()` constructors (dart-lang/co19#3392) R=athom@google.com, eernst@google.com Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I5b716643d82114746b70f1553383280eb30b4327 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463582 Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.